refactor: use host for watcher by lishaduck · Pull Request #2200 · flint-fyi/flint

lishaduck · 2026-01-31T04:42:51Z

PR Checklist

Addresses an existing open issue: followup to fix: ignore more in watcher #2168, as approved for addressing by Josh in fix: ignore more in watcher #2168 (review).
That issue was marked as status: accepting prs
Steps in CONTRIBUTING.md were taken

Overview

❤️‍🔥

I don't remember if this works, I whipped this up on a 6-hour car ride to Oklahoma yesterday.

vercel · 2026-01-31T04:42:56Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
flint	Ready	Preview, Comment	Feb 23, 2026 9:52pm

changeset-bot · 2026-01-31T04:42:56Z

⚠️ No Changeset found

Latest commit: 4a6f499

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

lishaduck · 2026-01-31T04:47:20Z

packages/cli/src/findConfigFileName.ts

+export function findConfigFileName(host: LinterHost) {
+	const children = new Set(
+		host.readDirectory(host.getCurrentDirectory()).map((file) => file.name),
+	);


I think we need the host to be async-first, blocking second. @auvred, is there a reason why the host is synchronous-first beyond that typescript is synchronous? Can we rename readDirectory to like readDirectorySync for ts and make readDirectory the promised version?

Also is there a reason getCurrentDirectory is a function? It's always constant. I really couldn't care less, if it's a style choice that's fine by me, but I'm mildly curious. Wouldn't it be more efficient (on a nano-optimization level ofc) to make it property?

I think we need the host to be async-first, blocking second. @auvred, is there a reason why the host is synchronous-first beyond that typescript is synchronous? Can we rename readDirectory to like readDirectorySync for ts and make readDirectory the promised version?

Yeah, it's synchronous only because ts.sys is synchronous. Adding a pair of async methods sounds pretty reasonable to me. We probably won't gain much speed from using async versions, but it's nice to have IMO.

Also is there a reason getCurrentDirectory is a function? It's always constant. I really couldn't care less, if it's a style choice that's fine by me, but I'm mildly curious. Wouldn't it be more efficient (on a nano-optimization level ofc) to make it property?

Since our LinterHosts are interface-based and designed to be layered on top of one another, it's easier to have getCurrentDirectory as a function (some LinterHost implementation may choose to override its behavior dynamically)

packages/cli/src/runCli.ts

packages/core/src/types/host.ts

lishaduck · 2026-01-31T04:56:41Z

We really need a better way to do stacked PRs, this is stacked on #2199 so I have to keep this in draft but that stops it from showing up the review queue when this is equally ready for review... 🤔

packages/core/src/types/host.ts

auvred · 2026-02-03T11:21:56Z

packages/core/src/types/host.ts

 }
+
+export interface WatchDirectoryOptions extends WatchOptions {
+	recursive: boolean;


WDYT about making recursive an optional? pollingInterval is optional, so it would be nice to be consistent. However, if you made this for the sake of explicitness, I'm okay with that!

if you made this for the sake of explicitness, I'm okay with that!

Yeah, it was required before so I was sticking with that. I don't know enough about watching to know what it makes sense to default to (aka why is recursive: false even a thing?) so I'm not going to touch it.

If anyone else feels does strongly though, please let me know! I'm happy to change it.

packages/core/src/host/createDiskBackedLinterHost.ts

auvred

Generally, I'm really positive about these changes!

packages/core/src/host/createDiskBackedLinterHost.ts

packages/core/src/host/createVFSLinterHost.ts

auvred · 2026-02-14T10:05:57Z

packages/core/src/host/createVFSLinterHost.ts

+		getFileTouchTimeSync() {
+			// TODO: uhh... this probably doesn't work amazingly
+			return Date.now();
+		},


+1 on filing this as a followup

I think Auvred's right here? He's more right than me that's for sure.

Co-authored-by: auvred <61150013+auvred@users.noreply.github.com>

auvred

Cool 💥

JoshuaKGoldberg

Hell yeah!!

lishaduck commented Jan 31, 2026

View reviewed changes

lishaduck force-pushed the hosted-cli2 branch from 098c55e to 7bafdf6 Compare January 31, 2026 20:14

lishaduck force-pushed the hosted-cli branch from b16a0a8 to 0dc9128 Compare January 31, 2026 20:14

vercel bot deployed to Preview January 31, 2026 20:16 View deployment

lishaduck force-pushed the hosted-cli2 branch from 7bafdf6 to 75d8f23 Compare February 1, 2026 03:18

lishaduck force-pushed the hosted-cli branch from 0dc9128 to f31bf9d Compare February 1, 2026 03:18

lishaduck requested review from JoshuaKGoldberg and auvred February 1, 2026 03:22

vercel bot deployed to Preview February 1, 2026 03:22 View deployment

lishaduck force-pushed the hosted-cli2 branch from 75d8f23 to 44e0308 Compare February 1, 2026 03:28

vercel bot deployed to Preview February 1, 2026 03:30 View deployment

Base automatically changed from hosted-cli to main February 3, 2026 11:09

auvred reviewed Feb 3, 2026

View reviewed changes

packages/core/src/types/host.ts Outdated Show resolved Hide resolved

auvred reviewed Feb 3, 2026

View reviewed changes

auvred added the status: waiting for author Needs an action taken by the original poster label Feb 3, 2026

lishaduck marked this pull request as ready for review February 3, 2026 20:06

lishaduck force-pushed the hosted-cli2 branch from 44e0308 to ee73947 Compare February 3, 2026 20:09

vercel bot deployed to Preview February 3, 2026 20:11 View deployment

vercel bot deployed to Preview February 4, 2026 01:49 View deployment

auvred requested changes Feb 9, 2026

View reviewed changes

packages/core/src/host/createDiskBackedLinterHost.ts Outdated Show resolved Hide resolved

lishaduck force-pushed the hosted-cli2 branch from 0f05925 to cd3cedf Compare February 9, 2026 19:24

vercel bot deployed to Preview February 9, 2026 19:29 View deployment

lishaduck mentioned this pull request Feb 10, 2026

refactor: make suggestions static #2294

Merged

3 tasks

auvred requested changes Feb 14, 2026

View reviewed changes

lishaduck added 3 commits February 14, 2026 11:58

refactor: use host for watcher

fe17c18

refactor: dispose watchers, not signaling

1b88fb7

refactor: preemptively rename host methods to *Sync

9cb2909

lishaduck force-pushed the hosted-cli2 branch from cd3cedf to ac543b1 Compare February 14, 2026 18:27

vercel bot deployed to Preview February 14, 2026 18:31 View deployment

feat: implement async i/o in host

3277b7b

lishaduck force-pushed the hosted-cli2 branch from ac543b1 to ac0f621 Compare February 14, 2026 18:36

vercel bot deployed to Preview February 14, 2026 18:38 View deployment

lishaduck and others added 3 commits February 14, 2026 12:45

fix: readFile should replace readFileSafe

7577f22

drop aborter

457683d

I think Auvred's right here? He's more right than me that's for sure.

review feedback

c641d80

Co-authored-by: auvred <61150013+auvred@users.noreply.github.com>

lishaduck force-pushed the hosted-cli2 branch from ac0f621 to c641d80 Compare February 14, 2026 18:45

vercel bot deployed to Preview February 14, 2026 18:47 View deployment

lishaduck removed the status: waiting for author Needs an action taken by the original poster label Feb 22, 2026

lishaduck requested a review from auvred February 22, 2026 23:13

cleanup host

d24c320

Co-authored-by: auvred <61150013+auvred@users.noreply.github.com>

vercel bot deployed to Preview February 23, 2026 21:42 View deployment

Merge branch 'main' into hosted-cli2

4a6f499

vercel bot deployed to Preview February 23, 2026 21:52 View deployment

auvred approved these changes Feb 24, 2026

View reviewed changes

auvred added the 1 approval One team member approved; we're now waiting for a second approval or for 2 business days to pass. label Feb 24, 2026

barrymichaeldoyle approved these changes Mar 1, 2026

View reviewed changes

barrymichaeldoyle added ready to merge 2+ team members approved; we're now waiting on the author to file followups and self-merge. and removed 1 approval One team member approved; we're now waiting for a second approval or for 2 business days to pass. labels Mar 1, 2026

JoshuaKGoldberg approved these changes Mar 1, 2026

View reviewed changes

JoshuaKGoldberg merged commit c504693 into main Mar 1, 2026
10 checks passed

JoshuaKGoldberg deleted the hosted-cli2 branch March 1, 2026 17:29

lishaduck mentioned this pull request Mar 11, 2026

feat: introduce Vue language #2316

Merged

3 tasks

Conversation

lishaduck commented Jan 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Checklist

Overview

Uh oh!

vercel bot commented Jan 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot bot commented Jan 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

lishaduck Jan 31, 2026

Choose a reason for hiding this comment

Uh oh!

auvred Feb 3, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

lishaduck commented Jan 31, 2026

Uh oh!

Uh oh!

auvred Feb 3, 2026

Choose a reason for hiding this comment

Uh oh!

lishaduck Feb 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

auvred left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

auvred Feb 14, 2026

Choose a reason for hiding this comment

Uh oh!

auvred left a comment

Choose a reason for hiding this comment

Uh oh!

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

lishaduck commented Jan 31, 2026 •

edited

Loading

vercel bot commented Jan 31, 2026 •

edited

Loading

changeset-bot bot commented Jan 31, 2026 •

edited

Loading

lishaduck Feb 3, 2026 •

edited

Loading